maxpublichub does not work correctly in adc when connecting

[Guenter]

I switched to flexhub a week ago and I'm really pleased with it :-)

There seems to be a bug in maxpublichubs check, but only in ADC protocol and only when I connect to the hub, not later on.

If I set it to 0, I cannot connect via adc and adcs; I always get the message

was redirected to: no.minslots.redirect.specified:8000 because: Connected to too many public hubs, you have: 1, the hub maximum is: 0

although the client is not connected to any public hub at all.

The same happens, if I set it to 1 and I'm connected to one public hub upon connection. Then it reports 2 public hubs and redirects the client. If I'm not connected to a public hub I can connect and when I connect to a public hub afterwards, I'm not redirected. So the bug seems only to occur, when I connect to the hub. The logic seems to be, that at connection time the new connection is counted as a public one.

In NMDC it works as it should.

Guenter

[FlipFlop™]

This is technically not a hub bug, but a client bug. It's the client that sends that 1 in the ADC BINF (BINF HN1) when connecting, at that time the client doesn't know yet if the user is regged or not.

You can use a CDM debug monitor to confirm that data being sent by your client. Only if there's no HN1 sent to the hub, then it's a hub bug indeed.

[Guenter]

I can confirm that it only happens with linuxdc++, not with Eiskaltdc++. I cannot test windows clients at the moment.

Guenter